Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update roleAssignments to the newest specs - batch 2 #2880

Merged
merged 18 commits into from
Aug 1, 2024
Merged

feat: update roleAssignments to the newest specs - batch 2 #2880

merged 18 commits into from
Aug 1, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Jul 31, 2024 •
edited
Loading

Description

roleAssignments - Update to newest specs (see #2008 for details)

Pipeline Reference

Pipeline
avm.res.aad.domain-service
avm.res.alerts-management.action-rule
avm.res.analysis-services.server
avm.res.app-configuration.configuration-store
avm.res.app.container-app
avm.res.app.job
avm.res.app.managed-environment
avm.res.automation.automation-account
avm.res.batch.batch-account
avm.res.cache.redis
avm.res.cdn.profile
avm.res.cognitive-services.account
avm.res.communication.communication-service
avm.res.communication.email-service
avm.res.compute.availability-set
avm.res.compute.disk-encryption-set
avm.res.compute.disk
avm.res.compute.gallery
avm.res.compute.image
avm.res.compute.proximity-placement-group
avm.res.compute.ssh-public-key
avm.res.compute.virtual-machine-scale-set
avm.res.compute.virtual-machine

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Jul 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 31, 2024
@krbar krbar changed the title feat: update roleAssignments to the newest specs - batch 1 feat: update roleAssignments to the newest specs - batch 2 Jul 31, 2024
@krbar krbar marked this pull request as ready for review July 31, 2024 19:04
@krbar krbar requested review from a team as code owners July 31, 2024 19:04
@krbar krbar requested review from a team as code owners July 31, 2024 19:04
@ahmadabdalla
Copy link
Contributor

@krbar quick question: if someone was using a previous version of a module and used role assignments, has it been tested that their existing role assignments are not impacted and they won't get a duplicate RBAC error? Doesn't sound it should be an issue based on the updates, but just double checking. Thank you 🙏🏻

oZakari
oZakari previously approved these changes Aug 1, 2024
View reviewed changes
@AlexanderSehr
Copy link
Contributor

@krbar quick question: if someone was using a previous version of a module and used role assignments, has it been tested that their existing role assignments are not impacted and they won't get a duplicate RBAC error? Doesn't sound it should be an issue based on the updates, but just double checking. Thank you 🙏🏻

Hey @ahmadabdalla,
it absolutely will be an issue. To help this, I tagged the corresponding issue and added a workaround for existing role assignments that are impacted here, essentially making use of the explicit name parameter.
Role assignments that would be affected are all that did not previously use the full role definition Id, but just the GUID or the name.

@AlexanderSehr AlexanderSehr merged commit d12278a into main Aug 1, 2024
5 checks passed
@AlexanderSehr AlexanderSehr deleted the users/krbar/rbac-update-batch2 branch August 1, 2024 08:18
@AlexanderSehr AlexanderSehr linked an issue Aug 3, 2024 that may be closed by this pull request
[AVM Question/Feedback]: Breaking Change - Role-Assignments name should be consistent & configurable #2008
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@oZakari oZakari oZakari left review comments

Assignees

@krbar krbar

Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Question/Feedback]: Breaking Change - Role-Assignments name should be consistent & configurable
4 participants
@krbar @ahmadabdalla @AlexanderSehr @oZakari